Open
Conversation
Add missing #include <algorithm> for std::any_of() and std::count_if()
Codecov Report
@@ Coverage Diff @@
## master #844 +/- ##
======================================
Coverage 78.6% 78.7%
======================================
Files 292 292
Lines 9951 9951
======================================
+ Hits 7824 7827 +3
+ Misses 2127 2124 -3
Continue to review full report at Codecov.
|
Add missing #include for std::find_if()
Add missing #include for std::find() usage
Add #include for std:find()
Add missing #include for std::transform()
add missing include
andescu
reviewed
May 18, 2020
Contributor
There was a problem hiding this comment.
Thanks for contributing to our repo!
You need to add DCO to your commit message and the commit message needs to have the following structure:
Summarize changes in around 50 characters or less.
Mandatory detailed explanatory text. Wrap it to about 72
characters or so. In some contexts, the first line is treated as the
subject of the commit and the rest of the text as the body. The
blank line separating the summary from the body is critical (unless
you omit the body entirely); various tools like `log`, `shortlog`
and `rebase` can get confused if you run the two together.
Explain the problem that this commit is solving. Focus on why you
are making this change as opposed to how (the code explains that).
Are there side effects or other unintuitive consequences of this
change? Here's the place to explain them.
Optional further paragraphs come after blank lines.
- Bullet points are okay, too.
- Typically a hyphen or asterisk is used for the bullet, preceded
by a single space, with blank lines in between, but conventions
vary here.
All commits need to reference a ticket, again separated by a blank
line from the commit message summary above:
Resolves: ABC-111, #123
Relates-To: ABC-333, #321
See also: ABC-432, #456, #789
Signed-off-by: FirstName LastName <firstname.lastname@here.com>
| #include "repositories/PartitionsRepository.h" | ||
| #include "repositories/PrefetchTilesRepository.h" | ||
|
|
||
| #include <algorithm> |
Contributor
There was a problem hiding this comment.
Please move up between own header and module headers.
See coding style guide -> https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
| #include "repositories/PartitionsRepository.h" | ||
| #include "repositories/PrefetchTilesRepository.h" | ||
|
|
||
| #include <algorithm> |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing #include for std::any_of() and std::count_if()